Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASN1 Integer & Timestamp encoding and add test files #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JRomainG
Copy link

While encoding an x509 certificate to protobuf and back, I encountered some issues parsing the certificate generated through x509_certificate::X509CertificateToDER.

I address 2 issues I found and add the test files I used in a dedicated directory. I still haven't been able to properly convert extensions from protobuf to DER, but since they are optional this could wait another pull request.

@google-cla
Copy link

google-cla bot commented Jan 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant