[launcher] Add launcher TEE server implementation #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkl73
force-pushed
the
hostserver
branch
2 times, most recently
from
6ea9e88
to
3fc9e39
Compare
jkl73
force-pushed
the
hostserver
branch
10 times, most recently
from
db05eb2
to
e8cc7b1
Compare
alexmwu
reviewed
Aug 4, 2023
launcher/server/server.go
Outdated
| attestationVerifierTokenFile = "attestation_verifier_claims_token" | ||
| ) | ||
|
|
||
| type attestHandler struct { |
There was a problem hiding this comment.
It seems like should be able to have the fields in attestHandler used by TeeServer. Having an attestHandler complicates a lot of this logic.
There was a problem hiding this comment.
Another way is to use closure in the New() function, but I think it is more complex and maybe harder to test. So I plan to leave this as here, the logic can be change later when implementing the actual logic.
jkl73
force-pushed
the
hostserver
branch
3 times, most recently
from
06d0ca2
to
4fc8132
Compare
|
PTAL @alexmwu @JoshuaKrstic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a server in the launcher to allow host <-> container communication.
Refactor container_runner.go, move some code to verifier/util.go
Export HostTokenPath
Tests to be added in a subsequent PR (as it'll require a new test Docker image).