Update wear compose scrollaway with timeout changes #2090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
changed the title
yschimke
reviewed
Mar 5, 2024
| @@ -50,7 +50,7 @@ internal class ScaffoldState { | |||
| Box( | |||
| modifier = Modifier | |||
| .fillMaxSize() | |||
| .scrollAway { | |||
| .scrollAway(true) { | |||
There was a problem hiding this comment.
Can we use named params?
Is this meant to be defaulted on? Would false be a better default? Or move this up to a param for AppScaffold/ScreenScaffold?
yschimke
approved these changes
Mar 5, 2024
|
@rajat4064g let me know if you are waiting on me for anything. |
There are more changes that need to be dropped in this branch regarding syncing the timer for TimeOut animations between material PositionIndicator and new ScrollAway. Will merge this PR when that is finalised. |
|
Going to close as it's got merge conflicts, reopen once it's ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding animations to scrollAway modifier.
TimeText will appear after 3s when scrolling stops in a list of items.