Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafe nav #2225

Merged
merged 7 commits into from
May 20, 2024
Merged

Typesafe nav #2225

merged 7 commits into from
May 20, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented May 7, 2024

WHAT

Support https://medium.com/androiddevelopers/navigation-compose-meet-type-safety-e081fb3cf2f8

WHY

Not supported in Wear Compose ATM

HOW

Checklist 馃搵

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke closed this May 7, 2024
@yschimke yschimke reopened this May 7, 2024
@yschimke yschimke requested a review from BowerSteve May 7, 2024 11:25
@yschimke
Copy link
Collaborator Author

yschimke commented May 7, 2024

@BowerSteve FYI only - if we want to add early support for this we can, might flush out some bugs, or let us confirm that transition animations work.

Not urgent at all.

@yschimke yschimke marked this pull request as ready for review May 16, 2024 18:59
@yschimke yschimke changed the title Experiment with typesafe nav Typesafe nav May 16, 2024
userSwipeEnabled,
state = state,
)
class WearComposeNavigatorDestinationBuilder(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BowerSteve having used this a lot recently, I'd love to land this. Works beautifully.

@yschimke yschimke merged commit fe299f5 into google:main May 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants