Transpose for reduce window. #21197
Open
Transpose for reduce window. #21197
+93
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Implements the transpose rule for general reduce window support. We do this by padding out the cotangents and running a reduce_window on the cotangents, using mostly the same windowing properties, with the specific difference in how we approach dilation and padding during the reduction (as these are accounted for during the padding of the cotangents). Note - that this CL highlights a small bug/issue in the tracing mechanism itself. We cannot reuse the primals side of the JVP, and are forced to recompute it, due to the fact that attempting to use primals from the initial JVP computation flags the primals side arrays as unknown. PiperOrigin-RevId: 632679634
copybara-service
bot
force-pushed
the
test_632679634
branch
from
bde9d31
to
0a22e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transpose for reduce window.
Implements the transpose rule for general reduce window support. We do this by padding out the cotangents and running a reduce_window on the cotangents, using mostly the same windowing properties, with the specific difference in how we approach dilation and padding during the reduction (as these are accounted for during the padding of the cotangents).
Note - that this CL highlights a small bug/issue in the tracing mechanism itself. We cannot reuse the primals side of the JVP, and are forced to recompute it, due to the fact that attempting to use primals from the initial JVP computation flags the primals side arrays as unknown.