jax.nn.softmax: only use initial=-inf when necessary #21264
+33
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_634465693
branch
4 times, most recently
from
266ed8f
to
f6813e4
Compare
The reason we need initial at all here is becuase when a user passes `where` or takes the softmax of an empty array, it is required. In other cases, the value does not affect the output, and may lead to unnecessary computation. Partially addresses #20856. PiperOrigin-RevId: 634465693
copybara-service
bot
force-pushed
the
test_634465693
branch
from
f6813e4
to
3b0db5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jax.nn.softmax: only use initial=-inf when necessary
The reason we need initial at all here is becuase when a user passes
whereor takes the softmax of an empty array, it is required. In other cases, the value does not affect the output, and may lead to unnecessary computation.Partially addresses #20856.