Removed noop # type: ignore comments #21273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it looks like some of the |
Can we use |
|
Yeah, we probably should. Will look into this. |
mypy should now flag these by default.
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
May 20, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 20, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
May 20, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 20, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
May 20, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 20, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 21, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 22, 2024
-- f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 by Sergei Lebedev <slebedev@google.com>: Removed noop # type: ignore comments mypy should now flag these by default. FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 635270794
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 22, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=google/jax#21273 from superbobry:mypy-ruff f5617d7323d6059022ec3e495e5d4d0fa3ccb1b1 PiperOrigin-RevId: 636147888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy should now flag these by default.