Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking details for Top Earning Pages Widget. #8259

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Feb 16, 2024

Summary

Addresses issue: #8212

Relevant technical choices

  • The IB mentions the use of forwardRef to pass down the ref to the Widget component. However this is not possible because of the use of HOC where we need to pass down the ref. It's easier to have the ref as part of the props which is automatically passed down to the Widget component with the use of HOCs.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

Build files for 270f2c0 are ready:

Copy link

Size Change: +333 B (0%)

Total Size: 1.49 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 23.6 kB +2 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 52.9 kB +23 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.3 kB +12 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 89.4 kB +15 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 108 kB +15 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 111 kB +231 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 91.8 kB +4 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.9 kB -2 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.5 kB +1 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 50.8 kB +1 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 42.3 kB -1 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 33.5 kB +16 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.8 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 50.8 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.1 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.38 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 929 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 778 B
./dist/assets/js/googlesitekit-api-********************.js 10 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.77 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.09 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 17.9 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.21 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 23.7 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-modules-analytics-********************.js 89.9 kB
./dist/assets/js/googlesitekit-modules-********************.js 22 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B
./dist/assets/js/googlesitekit-splash-********************.js 67.3 kB
./dist/assets/js/googlesitekit-vendor-********************.js 316 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant