Enhance/#8138 - Add the Audiences Widget Area happy path view #8672

hussain-t · 2024-05-07T12:28:47Z

Summary

Addresses issue:

Add the Audiences Widget Area happy path view #8138

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

github-actions · 2024-05-07T12:35:22Z

Build files for aab48f8 have been deleted.

github-actions · 2024-05-07T12:36:01Z

Size Change: +36.6 kB (+2.49%)

Total Size: 1.5 MB

Filename	Size	Change
`./dist/assets/css/googlesitekit-admin-css-********************.min.css`	54.1 kB	+26 B (+0.05%)
`./dist/assets/js/33-********************.js`	889 B	+1 B (+0.11%)
`./dist/assets/js/34-********************.js`	3.12 kB	+1 B (+0.03%)
`./dist/assets/js/googlesitekit-activation-********************.js`	23.9 kB	-12 B (-0.05%)
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	58.3 kB	+27 B (+0.05%)
`./dist/assets/js/googlesitekit-adminbar-********************.js`	34.6 kB	+23 B (+0.07%)
`./dist/assets/js/googlesitekit-api-********************.js`	10.1 kB	-5 B (-0.05%)
`./dist/assets/js/googlesitekit-components-gm2-********************.js`	5.88 kB	+2 B (+0.03%)
`./dist/assets/js/googlesitekit-components-gm3-********************.js`	10 kB	+3 B (+0.03%)
`./dist/assets/js/googlesitekit-data-********************.js`	2.18 kB	-1 B (-0.05%)
`./dist/assets/js/googlesitekit-datastore-forms-********************.js`	9.14 kB	-2 B (-0.02%)
`./dist/assets/js/googlesitekit-datastore-site-********************.js`	19.9 kB	+14 B (+0.07%)
`./dist/assets/js/googlesitekit-datastore-ui-********************.js`	10.1 kB	+6 B (+0.06%)
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	25.2 kB	-326 B (-1.28%)
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	72.7 kB	+361 B (+0.5%)
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	116 kB	+3.1 kB (+2.74%)
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	27.1 kB	+69 B (+0.26%)
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	111 kB	-4 B (0%)
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	129 kB	+17.7 kB (+15.95%)	⚠️
`./dist/assets/js/googlesitekit-modules-********************.js`	21.6 kB	+14 B (+0.06%)
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	22.5 kB	+32 B (+0.14%)
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	58.2 kB	+174 B (+0.3%)
`./dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	30.4 kB	-158 B (-0.52%)
`./dist/assets/js/googlesitekit-settings-********************.js`	60.4 kB	-4 B (-0.01%)
`./dist/assets/js/googlesitekit-splash-********************.js`	72.4 kB	-96 B (-0.13%)
`./dist/assets/js/googlesitekit-user-input-********************.js`	47.5 kB	-59 B (-0.12%)
`./dist/assets/js/googlesitekit-vendor-********************.js`	317 kB	-7 B (0%)
`./dist/assets/js/googlesitekit-widgets-********************.js`	49.4 kB	+15.7 kB (+46.6%)	🚨
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	60 kB	-33 B (-0.05%)
`./dist/assets/js/runtime-********************.js`	1.3 kB	+3 B (+0.23%)

ℹ️ View Unchanged

Filename	Size
`./dist/assets/css/googlesitekit-adminbar-css-********************.min.css`	11.2 kB
`./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css`	731 B
`./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css`	7.48 kB
`./dist/assets/js/29-********************.js`	2.8 kB
`./dist/assets/js/30-********************.js`	2.28 kB
`./dist/assets/js/31-********************.js`	3.72 kB
`./dist/assets/js/32-********************.js`	929 B
`./dist/assets/js/analytics-advanced-tracking-********************.js`	778 B
`./dist/assets/js/contact-form-7-********************.js`	646 B
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	2.09 kB
`./dist/assets/js/googlesitekit-i18n-********************.js`	3.92 kB
`./dist/assets/js/googlesitekit-polyfills-********************.js`	380 B
`./dist/assets/js/mailchimp-********************.js`	632 B
`./dist/assets/js/optin-monster-********************.js`	669 B
`./dist/assets/js/popup-maker-********************.js`	634 B
`./dist/assets/js/woocommerce-********************.js`	655 B
`./dist/assets/js/wpforms-********************.js`	634 B

_{compressed-size-action}

Add loaded prop.

Pass loaded prop to AudienceTile.

nfmohit

Nice work here, thank you @hussain-t !

While the code mostly looks good, I'm not able to fully test the behaviour of the tiles as the dashboard immediately crashes as soon as the report requests complete for the audience tiles.

Error

An error occurred while running 'mapSelect': A valid set of dimension names and values is required. 
    at ContentLinkComponent (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTilePagesMetric.js:68:25)
    at div
    at div
    at div
    at div
    at AudienceTilePagesMetric (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTilePagesMetric.js:55:23)
    at div
    at div
    at div
    at div
    at eval (webpack-internal:///./assets/js/googlesitekit/widgets/components/Widget.js:38:23)
    at AudienceTile (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/index.js:73:21)
    at div
    at div
    at div
    at eval (webpack-internal:///./assets/js/googlesitekit/widgets/components/Widget.js:38:23)
    at AudienceTilesWidget (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget.js:73:21)
    at WhenActiveComponent (webpack-internal:///./assets/js/util/when-active.js:58:20)
    at WidgetRenderer (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetRenderer.js:61:19)
    at div
    at Cell (webpack-internal:///./assets/js/material-components/layout/Cell.js:45:25)
    at WidgetCellWrapper (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetCellWrapper.js:39:30)
    at div
    at eval (webpack-internal:///./assets/js/material-components/layout/Row.js:44:24)
    at div
    at div
    at eval (webpack-internal:///./assets/js/material-components/layout/Grid.js:44:24)
    at WidgetAreaRenderer (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetAreaRenderer.js:97:19)
    at div
    at WidgetContextRenderer (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetContextRenderer.js:52:18)
    at DashboardMainApp (webpack-internal:///./assets/js/components/DashboardMainApp.js:112:106)
    at DashboardEntryPoint (webpack-internal:///./assets/js/components/DashboardEntryPoint.js:47:30)
    at RestoreSnapshots (webpack-internal:///./assets/js/components/RestoreSnapshots/index.js:47:23)
    at ErrorHandler (webpack-internal:///./assets/js/components/ErrorHandler/index.js:77:81)
    at ThemeProvider (webpack-internal:///./node_modules/@material-ui/styles/esm/ThemeProvider/ThemeProvider.js:42:24)
    at Root (webpack-internal:///./assets/js/components/Root/index.js:66:23)
overrideMethod @ console.js:273
useSelect @ index.js:127
ContentLinkComponent @ AudienceTilePagesMetric.js:62
renderWithHooks @ react-dom.development.js:14803
mountIndeterminateComponent @ react-dom.development.js:17482
beginWork @ react-dom.development.js:18596
beginWork$1 @ react-dom.development.js:23179
performUnitOfWork @ react-dom.development.js:22154
workLoopSync @ react-dom.development.js:22130
performSyncWorkOnRoot @ react-dom.development.js:21756
eval @ react-dom.development.js:11089
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushSyncCallbackQueueImpl @ react-dom.development.js:11084
flushSyncCallbackQueue @ react-dom.development.js:11072
scheduleUpdateOnFiber @ react-dom.development.js:21199
dispatchAction @ react-dom.development.js:15660
onStoreChange @ index.js:160
eval @ index.js:176
eval @ registry.js:76
globalListener @ registry.js:75
eval @ index.js:155
dispatch @ redux.js:306
s @ VM51034:3
eval @ index.js:30
eval @ promise-middleware.js:25
eval @ resolvers-cache-middleware.js:54
_callee$ @ index.js:349
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
Promise.then (async)
asyncGeneratorStep @ asyncToGenerator.js:15
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
setTimeout (async)
_callee2$ @ index.js:338
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
_fulfillSelector @ index.js:366
fulfillSelector @ index.js:306
selectorResolver @ index.js:369
eval @ report.js:395
eval @ report.js:395
selector @ factory.js:21
eval @ index.js:116
runSelector @ index.js:243
eval @ AudienceTilesWidget.js:188
useSelect @ index.js:113
AudienceTilesWidget @ AudienceTilesWidget.js:188
renderWithHooks @ react-dom.development.js:14803
mountIndeterminateComponent @ react-dom.development.js:17482
beginWork @ react-dom.development.js:18596
beginWork$1 @ react-dom.development.js:23179
performUnitOfWork @ react-dom.development.js:22154
workLoopSync @ react-dom.development.js:22130
performSyncWorkOnRoot @ react-dom.development.js:21756
eval @ react-dom.development.js:11089
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushSyncCallbackQueueImpl @ react-dom.development.js:11084
flushSyncCallbackQueue @ react-dom.development.js:11072
scheduleUpdateOnFiber @ react-dom.development.js:21199
dispatchAction @ react-dom.development.js:15660
onStoreChange @ index.js:160
eval @ index.js:176
eval @ registry.js:76
globalListener @ registry.js:75
eval @ index.js:155
dispatch @ redux.js:306
s @ VM51034:3
eval @ index.js:30
eval @ promise-middleware.js:25
eval @ resolvers-cache-middleware.js:54
dispatch @ redux.js:700
unhandledActionControl @ runtime.js:57
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
Promise.then (async)
eval @ runtime.js:43
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
any @ builtin.js:15
eval @ create.js:47
next @ create.js:46
unhandledActionControl @ runtime.js:58
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
any @ builtin.js:15
eval @ create.js:47
next @ create.js:46
unhandledActionControl @ runtime.js:58
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
iterate @ create.js:51
runtime @ create.js:73
iterator @ builtin.js:90
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
eval @ runtime.js:45
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
iterate @ create.js:51
runtime @ create.js:73
eval @ runtime.js:66
eval @ runtime.js:65
eval @ index.js:33
eval @ promise-middleware.js:25
eval @ resolvers-cache-middleware.js:54
_callee3$ @ index.js:431
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
fulfillResolver @ index.js:393
_callee$ @ index.js:346
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
setTimeout (async)
_callee2$ @ index.js:338
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
_fulfillSelector @ index.js:366
fulfillSelector @ index.js:306
selectorResolver @ index.js:369
eval @ audience-settings.js:258
selector @ factory.js:21
eval @ index.js:116
runSelector @ index.js:243
eval @ AudienceSegmentationSetupSuccessSubtleNotification.js:47
useSelect @ index.js:113
AudienceSegmentationSetupSuccessSubtleNotification @ AudienceSegmentationSetupSuccessSubtleNotification.js:47
renderWithHooks @ react-dom.development.js:14803
mountIndeterminateComponent @ react-dom.development.js:17482
beginWork @ react-dom.development.js:18596
beginWork$1 @ react-dom.development.js:23179
performUnitOfWork @ react-dom.development.js:22154
workLoopSync @ react-dom.development.js:22130
performSyncWorkOnRoot @ react-dom.development.js:21756
eval @ react-dom.development.js:11089
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushSyncCallbackQueueImpl @ react-dom.development.js:11084
flushSyncCallbackQueue @ react-dom.development.js:11072
scheduleUpdateOnFiber @ react-dom.development.js:21199
dispatchAction @ react-dom.development.js:15660
_callee$ @ index.js:40
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:3
_next @ asyncToGenerator.js:25
Promise.then (async)
asyncGeneratorStep @ asyncToGenerator.js:13
_next @ asyncToGenerator.js:25
eval @ asyncToGenerator.js:32
eval @ asyncToGenerator.js:21
eval @ index.js:37
commitHookEffectListMount @ react-dom.development.js:19731
commitPassiveHookEffects @ react-dom.development.js:19769
callCallback @ react-dom.development.js:188
invokeGuardedCallbackDev @ react-dom.development.js:237
invokeGuardedCallback @ react-dom.development.js:292
flushPassiveEffectsImpl @ react-dom.development.js:22853
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushPassiveEffects @ react-dom.development.js:22820
performSyncWorkOnRoot @ react-dom.development.js:21737
eval @ react-dom.development.js:11089
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushSyncCallbackQueueImpl @ react-dom.development.js:11084
flushSyncCallbackQueue @ react-dom.development.js:11072
scheduleUpdateOnFiber @ react-dom.development.js:21199
dispatchAction @ react-dom.development.js:15660
onStoreChange @ index.js:160
eval @ index.js:176
eval @ registry.js:76
globalListener @ registry.js:75
eval @ index.js:155
dispatch @ redux.js:306
s @ VM51034:3
eval @ index.js:30
eval @ promise-middleware.js:25
eval @ resolvers-cache-middleware.js:54
dispatch @ redux.js:700
unhandledActionControl @ runtime.js:57
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
Promise.then (async)
eval @ runtime.js:43
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
any @ builtin.js:15
eval @ create.js:47
next @ create.js:46
unhandledActionControl @ runtime.js:58
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
any @ builtin.js:15
eval @ create.js:47
next @ create.js:46
unhandledActionControl @ runtime.js:58
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
iterate @ create.js:51
runtime @ create.js:73
iterator @ builtin.js:90
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
eval @ runtime.js:45
eval @ create.js:47
next @ create.js:46
eval @ create.js:38
iterate @ create.js:51
runtime @ create.js:73
eval @ runtime.js:66
eval @ runtime.js:65
eval @ index.js:33
eval @ promise-middleware.js:25
eval @ resolvers-cache-middleware.js:54
_callee3$ @ index.js:431
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
_fulfillResolver @ index.js:440
fulfillResolver @ index.js:393
_callee$ @ index.js:346
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
setTimeout (async)
_callee2$ @ index.js:338
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:5
_next @ asyncToGenerator.js:27
eval @ asyncToGenerator.js:34
eval @ asyncToGenerator.js:23
_fulfillSelector @ index.js:366
fulfillSelector @ index.js:306
selectorResolver @ index.js:369
eval @ authentication.js:31
selector @ factory.js:21
eval @ index.js:116
runSelector @ index.js:243
eval @ index.js:28
useSelect @ index.js:113
PermissionsModal @ index.js:28
renderWithHooks @ react-dom.development.js:14803
mountIndeterminateComponent @ react-dom.development.js:17482
beginWork @ react-dom.development.js:18596
beginWork$1 @ react-dom.development.js:23179
performUnitOfWork @ react-dom.development.js:22154
workLoopSync @ react-dom.development.js:22130
performSyncWorkOnRoot @ react-dom.development.js:21756
scheduleUpdateOnFiber @ react-dom.development.js:21188
updateContainer @ react-dom.development.js:24373
eval @ react-dom.development.js:24758
unbatchedUpdates @ react-dom.development.js:21903
legacyRenderSubtreeIntoContainer @ react-dom.development.js:24757
render @ react-dom.development.js:24840
_callee$ @ googlesitekit-main-dashboard.js:57
tryCatch @ runtime.js:45
invoke @ runtime.js:274
prototype.<computed> @ runtime.js:97
asyncGeneratorStep @ asyncToGenerator.js:3
_next @ asyncToGenerator.js:25
eval @ asyncToGenerator.js:32
eval @ asyncToGenerator.js:21
Show 287 more frames
Show less
AudienceTilePagesMetric.js:62 An error occurred while running 'mapSelect': A valid set of dimension names and values is required. 
    at ContentLinkComponent (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTilePagesMetric.js:68:25)
    at div
    at div
    at div
    at div
    at AudienceTilePagesMetric (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTilePagesMetric.js:55:23)
    at div
    at div
    at div
    at div
    at eval (webpack-internal:///./assets/js/googlesitekit/widgets/components/Widget.js:38:23)
    at AudienceTile (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/index.js:73:21)
    at div
    at div
    at div
    at eval (webpack-internal:///./assets/js/googlesitekit/widgets/components/Widget.js:38:23)
    at AudienceTilesWidget (webpack-internal:///./assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget.js:73:21)
    at WhenActiveComponent (webpack-internal:///./assets/js/util/when-active.js:58:20)
    at WidgetRenderer (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetRenderer.js:61:19)
    at div
    at Cell (webpack-internal:///./assets/js/material-components/layout/Cell.js:45:25)
    at WidgetCellWrapper (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetCellWrapper.js:39:30)
    at div
    at eval (webpack-internal:///./assets/js/material-components/layout/Row.js:44:24)
    at div
    at div
    at eval (webpack-internal:///./assets/js/material-components/layout/Grid.js:44:24)
    at WidgetAreaRenderer (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetAreaRenderer.js:97:19)
    at div
    at WidgetContextRenderer (webpack-internal:///./assets/js/googlesitekit/widgets/components/WidgetContextRenderer.js:52:18)
    at DashboardMainApp (webpack-internal:///./assets/js/components/DashboardMainApp.js:112:106)
    at DashboardEntryPoint (webpack-internal:///./assets/js/components/DashboardEntryPoint.js:47:30)
    at RestoreSnapshots (webpack-internal:///./assets/js/components/RestoreSnapshots/index.js:47:23)
    at ErrorHandler (webpack-internal:///./assets/js/components/ErrorHandler/index.js:77:81)
    at ThemeProvider (webpack-internal:///./node_modules/@material-ui/styles/esm/ThemeProvider/ThemeProvider.js:42:24)
    at Root (webpack-internal:///./assets/js/components/Root/index.js:66:23)

This happens most likely because the array formation here adds specific indexes of report rows assuming that the report will include at least 3 rows, but in my case, it doesn't. As a result, the rest of the array items are set as undefined. I'm using the o*.i* property.

I don't think this is particularly an issue in your PR, but most likely a regression from a previous issue, as the audience tiles previously relied on mock data instead of real report data.

As discussed, this is now back with you to see if this can be fixed within this PR.

hussain-t · 2024-05-23T12:52:02Z

Thanks for raising this, @nfmohit. I've fixed the issue. So that you know, the test failure is not related to this PR.

nfmohit

Excellent work here as usual, thank you @hussain-t!

I have left some minimal feedback across your PR, after addressing which, we should be able to merge this immediately.

Please reach out if you have any questions, thank you!

assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceAreaFooter.js

assets/js/googlesitekit/widgets/register-defaults.js

...lytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTileCitiesMetric.js

...alytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTilePagesMetric.js

...odules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget.stories.js

assets/js/modules/analytics-4/datastore/report.js

...Components_AudienceSegmentation_Dashboard_AudienceTilesWidget_Default_0_document_0_small.png

assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget.js

nfmohit

LGTM, brilliant work, @hussain-t !

hussain-t added 11 commits May 7, 2024 17:27

Rename AudienceTiles to AudienceTilesWidget.

c911e4b

Rename AudienceTilesWidget stories file.

02a92fe

Export AudienceTilesWidget with whenActive hoc.

6c3d968

Add InfoNoticeWidget component.

844af8e

Add AudienceAreaFooter component.

d34816e

Export default.

b7fb602

Add settings.Footer and make settings.title optional.

fe04f5c

Add AREA_MAIN_DASHBOARD_TRAFFIC_AUDIENCE_SEGMENTATION const.

af18b5d

Register AREA_MAIN_DASHBOARD_TRAFFIC_AUDIENCE_SEGMENTATION widget area.

539e153

Render widget area Footer.

040302e

Register AudienceTilesWidget and InfoNoticeWidget widgets.

792ac1e

hussain-t added 15 commits May 9, 2024 16:01

Merge branch 'develop' into enhance/#8138-audience-widget-area.

f0178e5

Rendr PreviewBlock for loading.

fbf99f1

Add loaded prop.

Add isActive to analyticsAudienceTiles widget.

260e2f5

Add logic in AudienceAreaFooter.

015438b

Set noPadding for InfoNoticeWidget widget.

5dffe4b

Check if all the reports are loaded.

a5fffea

Pass loaded prop to AudienceTile.

Conditionally set the dimension values.

80ff619

Conditionall set the dimension values in AudienceTilePagesMetric.

1f66065

Apply source link styles.

c63c42b

Add loaded prop to the stories.

a363353

Fix AudienceTilesWidget by mocking modules.

d8ee1da

Update registerWidgetArea tests.

e1c7d8d

Merge branch 'develop' into enhance/#8138-audience-widget-area.

63c1180

Update AudienceTilesWidget VRT images.

30e5dfc

Merge branch 'develop' into enhance/#8138-audience-widget-area.

299f22f

nfmohit requested changes May 23, 2024

View reviewed changes

Fix dimension values being undefined in AudienceTileCitiesMetric.

89d3d82

hussain-t added 2 commits May 23, 2024 17:00

Fix dimension values being undefined in AudienceTilePagesMetric.

dd9c6d7

Merge branch 'develop' into enhance/#8138-audience-widget-area.

5d52fd2

nfmohit requested changes May 26, 2024

View reviewed changes

hussain-t and others added 9 commits May 27, 2024 10:46

Merge branch 'develop' into enhance/#8138-audience-widget-area.

8e9c6a7

Update component name in the header.

7edafa6

Rearrage imports.

7fb7fb9

Use Array.filter instead of some.

5ef18f5

Remove provideModuleRegistrations.

0866b0e

Remove log used for debugging.

6c9831d

Remove unused VRT images.

d63e277

Fix prevent NaN value by handling zero totalPageviews.

de47de3

Cast totalPageviews to be a number.

aab48f8

nfmohit approved these changes May 27, 2024

View reviewed changes

nfmohit merged commit 80fa5ea into develop May 27, 2024
21 of 22 checks passed

nfmohit deleted the enhance/#8138-audience-widget-area branch May 27, 2024 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance/#8138 - Add the Audiences Widget Area happy path view #8672

Enhance/#8138 - Add the Audiences Widget Area happy path view #8672

hussain-t commented May 7, 2024 •

edited by nfmohit

github-actions bot commented May 7, 2024 •

edited

github-actions bot commented May 7, 2024 •

edited

nfmohit left a comment

hussain-t commented May 23, 2024

nfmohit left a comment

nfmohit left a comment

Enhance/#8138 - Add the Audiences Widget Area happy path view #8672

Enhance/#8138 - Add the Audiences Widget Area happy path view #8672

Conversation

hussain-t commented May 7, 2024 • edited by nfmohit

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

github-actions bot commented May 7, 2024 • edited

github-actions bot commented May 7, 2024 • edited

nfmohit left a comment

Choose a reason for hiding this comment

hussain-t commented May 23, 2024

nfmohit left a comment

Choose a reason for hiding this comment

nfmohit left a comment

Choose a reason for hiding this comment

hussain-t commented May 7, 2024 •

edited by nfmohit

github-actions bot commented May 7, 2024 •

edited

github-actions bot commented May 7, 2024 •

edited